Playwright locator refactoring #6591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
playwright_tests
module, focusing on improving the handling of locators and ensuring DOM elements are fully loaded before interactions. The most important changes include replacingxpath
withLocator
for various methods, adding calls towait_for_dom_to_load
, and improving the handling of element interactions.Improvements to handling locators and DOM loading:
playwright_tests/core/basepage.py
: Replacedxpath
withLocator
for multiple methods, ensuring that locators are used consistently. Added calls towait_for_dom_to_load
before interacting with elements. [1] [2] [3] [4] [5] [6]playwright_tests/core/utilities.py
: Updated theupload_file
method to useLocator
instead ofxpath
and improved the handling of file uploads.playwright_tests/core/utilities.py
: Improved thedelete_cookies
method by replacingwait_for_selector
with_wait_for_locator
for better locator handling.playwright_tests/flows/auth_flows/auth_flow.py
: Simplified the__provide_login_credentials_and_submit
method by removing redundant checks and directly adding the password and submitting.