Skip to content

Playwright locator refactoring #6591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

emilghittasv
Copy link
Collaborator

This pull request includes several updates to the playwright_tests module, focusing on improving the handling of locators and ensuring DOM elements are fully loaded before interactions. The most important changes include replacing xpath with Locator for various methods, adding calls to wait_for_dom_to_load, and improving the handling of element interactions.

Improvements to handling locators and DOM loading:

@emilghittasv emilghittasv requested a review from escattone March 25, 2025 19:02
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes!

@emilghittasv emilghittasv merged commit ebac6a8 into mozilla:main Mar 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants